search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
285 stars 110 forks source link

Update .prettierrc.json #667

Closed MysticJay closed 1 year ago

MysticJay commented 1 year ago

GIT converts LineEndings to the locally used standard while downloading. In windows this is CRLF. Editors that suport linters/prettier complain about that for each line as the default for Prettier is LF. by adding "endOfLine": "auto" to prettierrc.json, prettier will accept the OS's default.

Please check if the setting causes any problems in your environment (it should not, but maybe you tweaked all your windows tools to work with LF too?)

(Please avoid discussions on IDEs/Windows/Linux/LF/CRFL.)

github-actions[bot] commented 1 year ago

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk b66c695b3e70d0163b3518287347d9bdcdd78089
test-0.36.1.20230812.102305.zip b66c695b3e70d0163b3518287347d9bdcdd78089

See build on website

xscreach commented 1 year ago

Shouldn't we rather set gitattributes for js files to be always checked out with LF? We do similar for other files so why not for js aswell?

MysticJay commented 1 year ago

defaulting to LF causes many windows tools to fail. I have been trying a lot to overcome this problem, but nothing worked out. This setting does not harm anything, (which I just want you to confirm). GIT is already downloading in the best way (auto) for your environment.

modos189 commented 1 year ago

I checked that I do indeed have the EOL-Test-File.js file loading as LF. Please remove this file for merge