search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
279 stars 105 forks source link

Bookmarks refactor: simplying API for adding a new portal #725

Closed nexushoratio closed 2 months ago

nexushoratio commented 2 months ago

Also adds jsdoc for the API being replaced.

nexushoratio commented 2 months ago

While, net code wise, there are now more lines, I think this new API would be easier for other plugins to use, rather than remembering how to properly build the latlng string and extract the portal name.

github-actions[bot] commented 2 months ago

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk fad6e625875ad138b5d2ed6698b97d2e67c1c552
test-0.38.1.20240418.080839.zip fad6e625875ad138b5d2ed6698b97d2e67c1c552

See build on website

nexushoratio commented 2 months ago

Hmmm... apparently rebasing to pick up the recent build fixes was not the right thing to do history wise? It looks like it mixed in @modos189 's changes with mine, which was not my intent.

I've not done a lot of work with git in a collaborative setting like this, so it is not surprising if I messed something up.

Regardless of the final disposition of this PR, guidance on git protocol in this case would be appreciated. :->

xscreach commented 2 months ago

Hmmm... apparently rebasing to pick up the recent build fixes was not the right thing to do history wise? It looks like it mixed in @modos189 's changes with mine, which was not my intent.

I've not done a lot of work with git in a collaborative setting like this, so it is not surprising if I messed something up.

Regardless of the final disposition of this PR, guidance on git protocol in this case would be appreciated. :->

You need to do rebase with "onto" to select the starting point...

Should be smth like this: git rebase 141e2d1b2 --onto master