Level 1 portals show incorrect "resonator level(s) needed for next portal level"

[Artoria2e5]

I have a portal that's level 1 from a single level 5 resonator. It should require 11 more resonator levels to become level 2. However, IITC says 8, probably because it doesn't quite understand how level 1 works differently from all other levels:

[Artoria2e5]

Specifically, https://github.com/IITC-CE/ingress-intel-total-conversion/blob/199c9f7bdc0acb79db3855f9f5cd7c0cd516ec66/core/code/portal_info.js#L14 applies a minimum clamp to the level, so that it does not return a number less than 1 when there's a resonator. However, https://github.com/IITC-CE/ingress-intel-total-conversion/blob/199c9f7bdc0acb79db3855f9f5cd7c0cd516ec66/core/code/portal_detail_display.js#L121 naively treats the detailed level as total level / 8.

[Artoria2e5]

Considering that the only references to getPortalLevel in this whole organization are:

• a deprecated.js
• this portal_detail_display.js
• portal_info.js, getPortalRange()

I'd think we can get away with removing the Math.max() in getPortalLevel. The only place where the max makes sense is in getPortalRange() -- we can just put it there!

[McBen]

and https://github.com/IITC-CE/ingress-intel-total-conversion/blob/199c9f7bdc0acb79db3855f9f5cd7c0cd516ec66/core/code/portal_info.js#L366-L370 it would handle the "without max" case, but makes the comments invalid