Open nexushoratio opened 3 weeks ago
DanielOndiordna
commented
3 weeks ago I do not have a Core subscription anymore, so it is difficult for me to develop this script any further without access to my inventory. I still have my old json data, so I can still work with that. I am curious what you have in mind. Creating a new fork is always possible, but if you want, I could add some new features to my fork.
xscreach
commented
3 weeks ago Imho the preffered way would be to pull the plugin among other core plugins so people can enable/disable it based on their core subscription.
But afaik, more and more developers are canceling the core subscription so we might not be able to maintain the code anyways ðĪ·ââïļ
But it's one of main ingress features so it makes sense to have it amongst core plugins
nexushoratio
commented
3 weeks ago Oh, cool!
Mostly cosmetic.
Keys:
Capsules:
Maybe make use of the new bookmarks API I added for bulk adding. Alas, Firefox again has an issue where adding keys one at a time (the way that this plugin does) is painfully slow. Honestly, the bulk API isn't much better, but at least then we can be sure to blame it on how jquery builds the bookmarks widget and now how localStorage is used on each add.
nexushoratio
commented
3 weeks ago more developers are canceling the core subscription
nexushoratio
commented
3 weeks ago Related: #438
modos189
commented
2 weeks ago You can create a fork and either submit changes to the author or add your plugin to the catalog.
We can modify the IITC code to make it easier to develop such plugins, but I think it is unnecessary to add C.O.R.E. to the main IITC
EisFrei
commented
2 weeks ago Hi, original author of live inventory here.
I'm playing Ingress very casually at this moment and don't have a core subscription anymore.
You are welcome to fork and create PRs that I'll happily accept.
nexushoratio
commented
2 weeks ago I feel like the catalog is where plugins go to die.
@DanielOndiordna 's is the one in the catalog currently. And @EisFrei just offered as well. So if I were to fork and catalog, then which is the "official" one? (Note: I would not fork and catalog, since they have commented on this thread.)
Like @xscreach , I feel that since this is a main feature of the game (even if paid), it would make sense for it to be part of the main code base (as a plugin). If it was collating info from another website or something, sure, but it is a major part of the game.
Also, if it was in the main code base, it might encourage more folks to subscribe, allowing Niantic to develop more features for the game. So, win-win?
modos189
commented
2 weeks ago I feel like the catalog is where plugins go to die.
It's only a catalog, and you can see new commits with plugin updates that appear there. Plugin development is done by developers in their repositories or their websites, from where changes are automatically uploaded to the catalog to make it easier to find plugins
modos189
commented
2 weeks ago Also, if it was in the main code base, it might encourage more folks to subscribe, allowing Niantic to develop more features for the game. So, win-win?
I don't have a C.O.R.E. subscription, how do I check PR with the addition of such features? Do I need to buy a subscription? Also, does everyone who wants to check PR also have to buy a subscription?
Also, we are not being paid by Niantic to promote subscriptions =)
xscreach
commented
2 weeks ago Also, we are not being paid by Niantic to promote subscriptions =)
Maybe that could change and NIA could finally acknowledge IITC as a supported/allowed third-party tool to use with ingress... lol, yeah, no comment ðĪŠð
On a serious note...
I agree that maintaining such a plugin won't be as easy as the rest of them just because we don't want to pay for the subscription. But there are plenty of people around who pay it and would be willing to do some testing around it if asked ðĪ·ââïļ Maybe it could bring more people willing to help us with all of this - we are always struggling with having active developers and testers around... there's always someone, but... interests change, life goes on etc...
But I think we can keep it rest now. The plugin has a maintainer here so I suggest doing the work there for now ð
nexushoratio
commented
2 weeks ago I don't have a C.O.R.E. subscription, how do I check PR with the addition of such features? Do I need to buy a subscription? Also, does everyone who wants to check PR also have to buy a subscription?
Of course not. But folks who do have such subscriptions can participate in reviews. And for cosmetic issues like I mentioned here, it would be appropriate for the plugin to have a way to an alternative way to provide test data (e.g., import). After all, I don't expect everyone to have keys to a portal with an obnoxiously long name. Or have as many unique keys as I do.
Also, we are not being paid by Niantic to promote subscriptions =)
Wait, you're getting paid by Niantic? (just not to promote subscriptions) ;->
nexushoratio
commented
2 weeks ago The plugin has a maintainer here so I suggest doing the work there for now ð
Actually, two. I'm not sure what to do. =panics=
Both the original and fork in the Community plugins repo are over three years old.
There are a few other forks as well, including one modified only a few months ago.
There are a couple of minor cosmetic issues I'd like to fix with that particular plugin, but both @EisFrei and @DanielOndiordna seem less involved these days. And I'd prefer not to make a fork of a fork.
Would it be possible to bring the features into the official IITC-CE code base some how?
If so, what would be the preferred method?