IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
291 stars 109 forks source link

Maps attribution is [partly] covered with IITC UI-elements #89

Open johnd0e opened 5 years ago

johnd0e commented 5 years ago

How we could fix it:

BTW, there was old issue: #865

MysticJay commented 3 years ago

IMHO there is no need to (constantly) show the Map attribution in IITC. IITC is run completely offline and not a webpage. It would be different if we would include a MAP on IITC.APP

But to honor the work of the MAP owners we should add the attribution info to the toolbox in an own menu item or add it to "about IITC". This will save us some space on the screen.

e.g. OSM requires the attribution for publishing any work based on the data (which IITC is not doing), but even allows to move that information to an "about" dialog. (https://wiki.openstreetmap.org/wiki/Open_Data_License/Use_Cases#Using_OSM_data_in_a_computer_game_together_with_other_data_sources) (https://wiki.openstreetmap.org/wiki/Open_Data_License/Use_Cases#Snapshots_of_mobile_device_applications)

le-jeu commented 3 years ago

Additionnal remark: map attribution (and any bottom right control) moves on sidebar collapse/expand

https://github.com/IITC-CE/ingress-intel-total-conversion/blob/a701aae55ab0c96ecdbe379473dac7973f2017d8/core/code/boot.js#L90

https://github.com/IITC-CE/ingress-intel-total-conversion/blob/a701aae55ab0c96ecdbe379473dac7973f2017d8/core/code/boot.js#L422-L428

#updatestatus could have fix height and .leaflet-bottom.leaflet-right either a margin-bottom or bottom set to this height.