IITGN-CS431 / project-cns

1 stars 27 forks source link

[Functionality BUG] Wrong IP address is HARD CODED - Group 2 #271

Closed RuchitJagodara closed 1 week ago

RuchitJagodara commented 1 week ago

Here, in server.py file and client.py file which are main executable files the group has hard coded a random IP address 10.7.23.164 and Port 12345. And as we are not allowed to temper with the code, I can't change the IP and Port here, as it is not allowed so basically if I run the file as it is it is giving me error, which should not happen by default because I am not missing anything here so it should work but it is giving error because of the same reason !

Screenshot from 2024-11-15 00-50-43 Screenshot from 2024-11-15 00-50-53

Here, is the ss of error message.

Screenshot from 2024-11-15 00-53-55

Although I agree that they have mentioned that we should use our own IP but still this should be considered as a bug because I can't change the code as it is tempering with the code !

Screenshot from 2024-11-15 00-46-05

And here instead of mentioning it, I think it is better to change the code to handle the default IP and Port according to values it can actually take without any errors like taking IP as 127.0.0.1 and port as any random value which is available !

naveeeeeeeeeen commented 1 week ago

Although it was not a bug as it is explicitly mentioned in the readme to put your ip and port but now we have provided a way to put ip and port number directly.

Screenshot from 2024-11-15 15-18-03 Screenshot from 2024-11-15 15-18-27

RuchitJagodara commented 1 week ago

Thank you for the update ! @bichhawat can you please mark this as a bug ?