IITGN-CS431 / project-cns

0 stars 1 forks source link

Functionality Bug (Group-2): Invalid Room ID Accepted (logappend) #3

Open dkshjn opened 18 hours ago

dkshjn commented 18 hours ago

Functionality Bug (Group-2): Invalid Room ID Accepted (logappend)

Description

The system allows appending an entry with an invalid room ID (-1), which violates the specification that room IDs should be non-negative integers. Even though the room ID is invalid, the entry is still added to the log and later shown by logread. There is no validation in place to check the correctness of the room ID, leading to incorrect entries in the log.

Demonstration

As shown in the attached image, the system accepts a log entry with an invalid room ID -1. The logappend command processes the entry without checking the validity of the room ID, and the logread command displays the invalid room ID in the output.

Screenshot 2024-10-23 at 11 00 34 PM

Reported by: Daksh Jain(22110066)

naveeeeeeeeeen commented 6 hours ago

I have Fixed this bug and Created a pull request. Sample Output:- Screenshot from 2024-10-24 11-48-17