Closed chirag200666 closed 9 years ago
Does the 'in progress' tag on PRs means the PR is not ready for merge? If so, I'd like if somebody document this rule somewhere in some doc
If that is how 'in progress' in used, then I got it wrong (I thought it was added to filter out PRs being worked on actively). This PR is ready to be merged. I will remove the tag.
Heh. I've never seen tags on PRs :) I've only seen it to categorize/group/filter bugs. That's why I was curious what a tag is supposed to be meant on a PR. I guess if a PR is posted, it implicitly means it is ready to be reviewed and merged.. I might be wrong though..
The PR looks okay to me. I cannot run a local server right now, to test if it functions correctly, so you can say it's a +1 from me, and merge it by yourself, or wait for @ajayaa to have a look.
User will be forwarded to view profile page after creating his profile. Added a link in the auth home for view profile, after going to view profile, user can edit as well. Changed the description a bit on Readme.