search

IITH / alumni-portal

Alumni portal for IIT Hyderabad
12 stars 11 forks source link

Static file includes now being done the django way. #18

Closed chirag200666 closed 9 years ago

chirag200666 commented 9 years ago

changing the static file includes in templates from 'kind of hardcoding' to 'django staticfiles includes'. e.g. /static/js/jquery.min.js to {% static 'js/jquery.min.js' %} as static url '/static' is already mentioned in settings.py

rushiagr commented 9 years ago

Looks good mostly, except one typo. We're using single quotes inside the template syntax. Let's keep this behavior consistent even in future (as we could have very well used double quotes too instead).

chirag200666 commented 9 years ago

@rushiagr Fixing the typo. When we are including static image files in the page. e.g. < img src="{% url "img/1.jpg" %} "> some text editors are not cool with double quotes inside double quotes, so I prefer keeping the url and static quotes small for that season.