search

IIoW / IIslander

The IIslander Discord bot for the IIslands of War Discord server
https://store.steampowered.com/app/1162470/IIslands_of_War/
MIT License
6 stars 1 forks source link

Bug: no screening #259

Closed KommentatorForAll closed 1 year ago

KommentatorForAll commented 2 years ago

Describe the bug

there is no screening for new members, because we immediately apply roles to them, therefore automatically skipping the member screening. This allowes easier access for bots into the server and other fake spam accounts

Steps to reproduce

join the server

Expected behavior

member get screened and have to interact with something

Screenshots

No response

Additional context

No response

KommentatorForAll commented 2 years ago

member.pending exists, true while not finished screening, emits a onGuildMemberUpdate when done screening.

KommentatorForAll commented 2 years ago

probably gonna implement on wednesday

WilsontheWolf commented 2 years ago

It should be as simle as just moving the join code related to roles, to the guildMemberUpdate event and only run if pending.

WilsontheWolf commented 2 years ago

I would also consider this a feature/enhancment, as its not something wrong with our code, but implementing something new

WilsontheWolf commented 1 year ago

Fixed in #260