IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

Newly created entries not automatically committed #246

Open sc-perth opened 8 years ago

sc-perth commented 8 years ago

Using QtPass 1.1.5 on Windows 10 configured to use native git & gpg. When I create a new entry, the new entry is not automatically committed in git. After editing the entry, it will be committed to git. Shouldn't new entries be automatically committed to git?

Steps to reproduce.

On Windows 10, in a new or existing password store that has been initialized by git & is being accessed via QtPass: CLI: cd into the password store and run git status Output needs to be:

$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean

QtPass: Click the Add button, fill out all prompts. You should now have a new entry under the name you specified. CLI: run git status

Expected results:

$ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
nothing to commit, working tree clean

Actual results:

$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

        new file:   admin/test.gpg

QtPass: Select your new entry & click the Edit button. Make some modification and click OK. CLI: run git status

Expected results:

$ git status
On branch master
Your branch is ahead of 'origin/master' by 2 commits.
  (use "git push" to publish your local commits)
nothing to commit, working tree clean

Actual results:

$ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
nothing to commit, working tree clean
sc-perth commented 8 years ago

Note for others affected: You can choose to edit the entry, make no changes, and click OK to force the commit.

sc-perth commented 7 years ago

Huh, behavior isn't reliable on my computer? Capture.png What's different? I checked the show password option, changed password generator's character set, & clicked the generate password button a few times.