IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

New scroll bar on large files #347

Closed destanyol closed 6 years ago

destanyol commented 6 years ago

Changed the style of the scroll bar when the text file containing the password is larger than usual. I have never used Qt and I am on Linux KDE so I don't know if the change is global.

newscroll oldscroll

annejan commented 6 years ago

Works on macOS . . well..

screen shot 2018-01-12 at 02 00 12 Before

screen shot 2018-01-12 at 02 01 00 After

screen shot 2018-01-12 at 02 18 07When hovering

screen shot 2018-01-12 at 02 18 11After clicking

This seems to be completely ignoring your styling and taking native rendering for some reason.

codecov[bot] commented 6 years ago

Codecov Report

Merging #347 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #347   +/-   ##
======================================
  Coverage    2.92%   2.92%           
======================================
  Files          36      36           
  Lines        2698    2698           
  Branches      360     360           
======================================
  Hits           79      79           
  Misses       2618    2618           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad455b4...5da03c4. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.0004%) to 1.776% when pulling 5da03c4daeff2814711eb9fc52891966d0445664 on destanyol:patch-1 into ad455b461b8c4858d039ea763ad5d9c7158e706f on IJHack:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.0004%) to 1.776% when pulling 5da03c4daeff2814711eb9fc52891966d0445664 on destanyol:patch-1 into ad455b461b8c4858d039ea763ad5d9c7158e706f on IJHack:master.

lukedirtwalker commented 6 years ago

This change changed the background of file content to white. Was that intended? I liked it more how it was previously.

destanyol commented 6 years ago

Ouch it's true, on my Linux it didn't change. I will take a look when I have some spare time. I'm sorry...

jounathaen commented 6 years ago

I'm really not an expert on this, but my first guess would be, that you only have to remove these lines from the commit:

+             setStyleSheet(QString::fromUtf8(QScrollBar:vertical {              
+              border: 1px solid #999999;
+              background:white;
+              width:10px;    
+              margin: 0px 0px 0px 0px;
+             }
destanyol commented 6 years ago

Sorry I forgot about this... Today I have tried to solve the changes on the background color but I have never used QT before and I have failed. I'm so sorry... I have created a new pull request reverting the changes done here.