Parallel make issue in qtpass-1.2.1: ld: cannot find -lqtpass

IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.

https://qtpass.org/

GNU General Public License v3.0

1.03k stars 162 forks source link

Parallel make issue in qtpass-1.2.1: ld: cannot find -lqtpass #350

Closed devurandom closed 6 years ago

devurandom commented 6 years ago

There appears to be a dependency issue between the qtpass binary and libqtpass.so:

x86_64-pc-linux-gnu-g++ -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -o qtpass main.o qrc_resources.o   -L/var/tmp/portage/app-admin/qtpass-1.2.1/work/QtPass-1.2.1/main/../src/./ -lqtpass -lQt5Widgets -lQt5Gui -lQt5Network -lQt5Core -lGL -lpthread
/usr/lib/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lqtpass
collect2: error: ld returned 1 exit status

build.log

See-Also: https://bugs.gentoo.org/643526

devurandom commented 6 years ago

The issue appears to be that the main target depends on tests instead of src (https://github.com/gentoo/gentoo/pull/6794/commits/55c9e8be77f735a76ef5735da3a89f9dcb8a055c#diff-113e371887b4ff371cb56eae3d4a0deaR42) and Gentoo tries to opt out of the tests, breaking the dependency chain. It would be great, if qtpass could support this a little bit better by depending on src directly.

annejan commented 6 years ago

main should depend on src and tests should depend on main

I have no idea why this was reversed but it seems to work at-least as well in the correct as the way it was . .

This is now fixed in master branch.