IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

Optimizations :) #367

Closed FiloSpaTeam closed 6 years ago

FiloSpaTeam commented 6 years ago

First of all i refactored QtPassSettings itself. Later i cleaned up some business logic about PasswordDialog in MainWindow.

Should run faster now :)

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 6.073% when pulling c18bf182c076c279688b2e0158bb6fe8776b7f08 on UnitooTeam:master into f04322cf1e533760911c63854aa5aea01db23473 on IJHack:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 6.073% when pulling c18bf182c076c279688b2e0158bb6fe8776b7f08 on UnitooTeam:master into f04322cf1e533760911c63854aa5aea01db23473 on IJHack:master.

codecov[bot] commented 6 years ago

Codecov Report

Merging #367 into master will decrease coverage by 0.3%. The diff coverage is 7.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #367      +/-   ##
=========================================
- Coverage    6.37%   6.07%   -0.31%     
=========================================
  Files          39      39              
  Lines        2713    2700      -13     
  Branches      355     347       -8     
=========================================
- Hits          173     164       -9     
+ Misses       2534    2530       -4     
  Partials        6       6
Impacted Files Coverage Δ
src/mainwindow.h 0% <ø> (ø) :arrow_up:
src/mainwindow.cpp 0% <0%> (ø) :arrow_up:
src/qtpasssettings.h 0% <0%> (ø) :arrow_up:
src/qtpasssettings.cpp 0.9% <0.45%> (-1.91%) :arrow_down:
src/settingsconstants.cpp 98.03% <100%> (ø) :arrow_up:
src/passworddialog.cpp 58.06% <37.5%> (-16.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f04322c...c18bf18. Read the comment docs.