Closed FiloSpaTeam closed 6 years ago
Merging #367 into master will decrease coverage by
0.3%
. The diff coverage is7.16%
.
@@ Coverage Diff @@
## master #367 +/- ##
=========================================
- Coverage 6.37% 6.07% -0.31%
=========================================
Files 39 39
Lines 2713 2700 -13
Branches 355 347 -8
=========================================
- Hits 173 164 -9
+ Misses 2534 2530 -4
Partials 6 6
Impacted Files | Coverage Δ | |
---|---|---|
src/mainwindow.h | 0% <ø> (ø) |
:arrow_up: |
src/mainwindow.cpp | 0% <0%> (ø) |
:arrow_up: |
src/qtpasssettings.h | 0% <0%> (ø) |
:arrow_up: |
src/qtpasssettings.cpp | 0.9% <0.45%> (-1.91%) |
:arrow_down: |
src/settingsconstants.cpp | 98.03% <100%> (ø) |
:arrow_up: |
src/passworddialog.cpp | 58.06% <37.5%> (-16.61%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f04322c...c18bf18. Read the comment docs.
First of all i refactored
QtPassSettings
itself. Later i cleaned up some business logic aboutPasswordDialog
inMainWindow
.Should run faster now :)