search

IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

No icons on macOS #377

Closed vanyasem closed 6 years ago

vanyasem commented 6 years ago

I have installed QtPass from brew, no icons are rendered

annejan commented 6 years ago

Thanks for creating this issue.

The missing icons and other (button) icon issues have been fixed in https://github.com/IJHack/QtPass/commit/1caf6d74e1cac10ebf3f3264b2d92e122a80fc15, https://github.com/IJHack/QtPass/commit/35ec5a44d39735fb55fd7f69ee7fd408379bd3a9 and https://github.com/IJHack/QtPass/commit/172189b7ae775a6c04a542107e6d08ee86bd15fb and all those improvements will be included in the next release.

I'll close this issue once the new release is out and hooked into the brew cask repository.

FiloSpaTeam commented 6 years ago

This should be fixed now, right?

annejan commented 6 years ago

Yes, fixed in master but as I noted above: I'll close this issue once the new release is out and hooked into the brew cask repository.

So I'll keep this issue open for now 😉 Will probably be able to close in a day or two 😁

FiloSpaTeam commented 6 years ago

Yooo :dancer: :dancer:

annejan commented 6 years ago

https://github.com/caskroom/homebrew-cask/pull/46803

annejan commented 6 years ago

Merged