maciejsszmigiero commented 5 years ago

This PR contains the following build system related fixes:

Currently, if one changes some source file in src and then runs make the libqtpass.a gets correctly rebuilt, however main/qtpass isn't actually relinked to make use of this new library version. According to the qmake project file snippet at the very bottom of https://doc.qt.io/qtcreator/creator-project-qmake-libraries.html internal static libraries need to be manually added to their users PRE_TARGETDEPS, too.
Fix the issue that make always considers libqtpass.a out of date and rebuilds it.
Make sure that resources are built just once.
Small fixes like localization/*.ts files unnecessairly maked executable or a forgotten localization file left over in qtpass.pro.

coveralls commented 5 years ago

Coverage remained the same at 7.049% when pulling 65aa4957ad0167880ef990bb355b8bdcd2875b7d on maciejsszmigiero:build-fixes into 8f2b87b36bd74f1c104653bf22150185125c365c on IJHack:master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #479 into master will decrease coverage by <.01%. The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #479      +/-   ##
=========================================
- Coverage    7.46%   7.46%   -0.01%     
=========================================
  Files          44      44              
  Lines        2812    2813       +1     
=========================================
  Hits          210     210              
- Misses       2602    2603       +1

Impacted Files	Coverage Δ
main/main.cpp	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f2b87b...65aa495. Read the comment docs.

IJHack / QtPass

Build system related fixes #479

Codecov Report