IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

gpg not found on macOS #575

Closed kenji21 closed 3 years ago

kenji21 commented 3 years ago

Describe the bug QtPass shows: /usr/local/bin/pass: line 388: gpg: command not found

To Reproduce Steps to reproduce the behavior:

  1. Try to show a password

Expected behavior no error

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context

QtPass tries to execute:

bash /usr/local/bin/pass show some/password

but PATH injected is :

PATH=/usr/bin:/bin:/usr/sbin:/sbin

as gpg binary is in /usr/local/bin/, it is not found since pass command define it:

GPG="gpg"

since 2014

Workaround by adding PATH=/usr/local/bin/:$PATH on top of the pass command

But I assume env is patched here: https://github.com/IJHack/QtPass/blob/master/src/pass.cpp#L51

but never injected within Executor instance

kenji21 commented 3 years ago

works on current master 89e759b9