IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.01k stars 158 forks source link

The password display should not distinguish the first line from all following #586

Open l3u opened 2 years ago

l3u commented 2 years ago

Currently, the password display consists of a "Password" label followed by the first line of the decrypted password file and a text area containing all following lines.

The pass program itself does not distinguish between single-line and multi-line password files. Every entry is a file, no matter how many lines are stored.

This leads to unexpected behavior, at least for me as a console pass user. First thing is that the first line of a pass file is not necessarily a "Password", and the second thing is that – for multi line files – I format my stuff to be lined up indended by spaces. This problem could easily be solved by using a fixed-width font, as already requested in issue #577. I personally would also make that font configurable to that a "good" one can be chosen, with definitely distinct characters.

But apart from the font issue, the decrypted file should be displayed as-is: Line by line, the first line in the exact same way all following lines are displayed. Just as pass does it on the console.

E.g. if you store a 63 character long WPA3 key, it's squitched inside that one-line line input, clipped on the top and bottom, along with an up- and down-arrow. Or if you save some file with multiple lines, and the first line is just a header, it is displayed as the "Password", and the rest follows below in another widget.

I'd probably simply use a QTextEdit with a monospace font and no line wrapping …

l3u commented 2 years ago

Everything bitched about here is fixed/added in PR #587 ;-)