IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.01k stars 158 forks source link

Add more options for the password displaying #587

Closed l3u closed 1 year ago

l3u commented 2 years ago

This addresses both issue #586 and issue #577.

I added two additional checkboxes to the configuration dialog:

Imo this won't hurt, as the default behavior remains unchanged, but it's convenient for console pass users that want to have the same behavior in QtPass.

l3u commented 2 years ago

Just to say it: I adapted the way you did it, like

void QtPassSettings::setNoLineWrapping(const bool &noLineWrapping) {
  getInstance()->setValue(SettingsConstants::noLineWrapping, noLineWrapping);
}

but in such a case, it's not really meaningful to use a const reference to a bool value. The pointer to the bool value is bigger than the value itself, so it's actually worse than simply passing the variable by value ;-)

But this is another story …