IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

qtpass do not strip comments of gpg_id file #625

Closed shemeshg closed 1 year ago

shemeshg commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

in pass we have (line 101)

    local gpg_id
    while read -r gpg_id; do
        gpg_id="${gpg_id%%#*}" # strip comment
        [[ -n $gpg_id ]] || continue
        GPG_RECIPIENT_ARGS+=( "-r" "$gpg_id" )
        GPG_RECIPIENTS+=( "$gpg_id" )
    done < "$current"

however QtPass consider the complete line as UserId and no whatever before the ' # ' only

To Reproduce Steps to reproduce the behavior: Create gpg_id entry in the .gpg_id file with remarks

21347213469hdsaklfha # username <username@whatever.com>

Expected behavior QtPass should not care if entry has ramarks or not.

Desktop (please complete the following information):

probably fine tune of issue #452

annejan commented 1 year ago

Fxied in 1.4.0

shemeshg commented 1 year ago

Still not fixed therefore created PR #658, Tested and with the PR, the users with comment in the gpg_id are now recognized.