IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

qtpass do not strip comments of gpg_id file #658

Closed shemeshg closed 1 year ago

shemeshg commented 1 year ago

See #625

Hi

it was not fixed in recent version of qtPass, it just striped spaces and did not split by "#"

You test that, by seeing that the checklist of the userdialog.cpp did not checked the existed users with #

I think we expected

selected_users = QtPassSettings::getPass()->listKeys(recipients);
  foreach (const UserInfo &sel, selected_users) {
    for (auto &user : users)
      if (sel.key_id == user.key_id)
        user.enabled = true;
  }

todo the right thing but listKeys(recipients) don`t return anything as examined by debugger.

before ->listKeys(recipients)

Screen Shot 2023-09-24 at 4 15 50

After ->listKeys(recipients) Screen Shot 2023-09-24 at 4 14 53