search

ILLISIS / Constructron-Continued

Other
13 stars 21 forks source link

added Constructron variants of Space Spidertron and Spidertron Extended #114

Closed TheElec closed 10 months ago

TheElec commented 1 year ago

Which file would be best for defining is_valid_constructron and is_flying_constructron? I assumed script/constructron.lua but script/Spidertron-pathfinder.lua doesn't require it.

heinwessels commented 1 year ago

Which file would be best for defining is_valid_constructron and is_flying_constructron? I assumed script/constructron.lua but script/Spidertron-pathfinder.lua doesn't require it.

I'm not sure. Personally I would create a dedicated config.lua file where such things can be defined, but it's better to ask @ILLISIS .

ILLISIS commented 1 year ago

Which file would be best for defining is_valid_constructron and is_flying_constructron? I assumed script/constructron.lua but script/Spidertron-pathfinder.lua doesn't require it.

I'm not sure. Personally I would create a dedicated config.lua file where such things can be defined, but it's better to ask @ILLISIS .

Spidertron-pathfinder.lua is the old path finder that I was keeping in the repo for easy access for the next few versions.. pathfinder.lua is the version that is in use.

As for where to define the table.. that is a difficult one.. I have separated entity handling into a new file for the next version and plan to do the same for job processing. So I don't really know at this stage.

TheElec commented 1 year ago

I moved the table to script/config.lua for now.

KeinNiemand commented 1 year ago

Instead of manually adding suppot for a few modded spidertrons woudn't it be much better to add universal support for all modded spidertrons by copying and creating a constructron version of every spidertron in the game? I made an issue for that and I may or may create a PR for that.