search

ILLIXR / ILLIXR

ILLIXR: Illinois Extended Reality Testbed
Other
129 stars 45 forks source link

Unify file io - issue #118 #416

Open astro-friedel opened 8 months ago

astro-friedel commented 8 months ago

This addresses issue #118. The file loading has been compacted into a single header. The header code will check for file existence and open it. Anything that want to use this functionality will need to supply a function which actually reads the data into the proper structures.

Jebbly commented 1 month ago

Overall the changes look fine and can be merged soon, but I'm not sure if this fully addresses #118. My impression of that issue is that we want a central plugin that can replay things, rather than having a separate plugin for each data file.

jianxiapyh commented 1 month ago

Overall, this looks solid and is a step towards addressing #118. However, it may not fully resolve the issue yet.

@Jebbly , as you know, the XR Fellowship member was working on a universal dataset reader in #393 some times ago but didn't complete it before stepping away. Now that it seems he is back, we can check on the status of that solution and see if it can complement this approach.

wermos commented 3 weeks ago

This is definitely something I can use in my dataset plugin (now #429) once it makes it in.