search

IM3S / LDAR_Sim

MIT License
2 stars 0 forks source link

User prompt for pregen leaks vs. batch running #138

Closed tbarchyn closed 2 years ago

tbarchyn commented 2 years ago

Is there benefit introducing a parameter to turn this user interface prompt off, or opposite, turning it on?

Just nervous about this as celery tasks will timeout and fail in web app if this ever pops up in production. (I realize I probably approved this in a PR a few months back!, sorry for flip flop).

https://github.com/IM3S/LDAR_Sim/blob/71ddd67077bfa54c744c9dd1fa1b04e877152d5f/LDAR_Sim/src/ldar_sim_main.py#L82

KeeganShaw-GIS commented 2 years ago

@tbarchyn Yeah we probably could add it as an input. There isn't any checking done on the pickle file at the moment, so its kind of up to the user. I guess I would say we disable by default and add a parameter in.

KeeganShaw-GIS commented 2 years ago

This has been fixed , if files have changed it will overwrite,