IMA-WorldHealth / bhima-1.X

A hospital information system for developing countries.
GNU General Public License v2.0
10 stars 14 forks source link

Create a Language Service #667

Open jniles opened 8 years ago

jniles commented 8 years ago

A good refactor would be to remove language ($translate) handling logic into a single service accessible from any controller that needed it. There are three controllers that currently make use of language - LoginController, SettingsController and ApplicationController. Since the language is an application-wide setting, it would be valuable to handle that logic in a shared service, which loads the default language and handles switching languages.

sfount commented 8 years ago

You just beat me to creating #668. Once we agree on what the missing relationship/ configuration/ definition should be, these two could be handled together.

jniles commented 8 years ago

Sounds good!