Hard Coded Values

[sfount]

There have been many cases when we are in a rush to release a feature that we hard code in a value to make something look complete - this is fine for a temporary fix; however we must make sure there are no examples of this in the development or master branches.

I will include as many as I can here - if you come across additional examples please comment them here, between us we should be able to make sure the entire application is driven by real data.

• [ ] partials/reports/trialbalance/print {{ amount | currency:2}}
• [ ] partials/reports/trialbalance/trialbalance {{ amount | currency:2}}
• [ ] partials/patient/registration/registration packagePatient.reference = 1;

[jniles]

There are a couple places in the journal.js code where the code reads result.project_id = 1 // HBB. I am fixing those in my branch, but it is the same type of issue, and we should be vigilant not to let those slip into production. I'm sure if you look at the code running at Tshikaji, you will find all of these issues.

[jniles]

@sfount, are these fixed?

[sfount]

They are not. I had planned to spend a few hours collecting all of these so that once we have addressed this we can be confident there are no parts of BHIMA that will break because of hardcoded values. I haven't been able to do this yet and this is still an open issue.

[jniles]

In the purchase receipt template, there is this line:

{{ model.common.enterprise.po_box || 'B.P. 205' }}<br>

I'm changing this specific one, but I'm sure it exists in other receipt templates.