search

IMA-WorldHealth / bhima-1.X

A hospital information system for developing countries.
GNU General Public License v2.0
10 stars 14 forks source link

FEAT(di): require strict dependency injection #833

Closed jniles closed 9 years ago

jniles commented 9 years ago

Since we have agreed to use Controller.$inject syntax (#719), and are compiling all our scripts through gulp, we can get some speed gains by adding the strict DI mode directive to the main application. For more details, see this link.

I've tested most of the modules, and this change leaves them unaffected. However, if we do find issues, we might want to add ng-annotate to our gulp build.

DedrickEnc commented 9 years ago

According to angular doc, it should be used in production. Did you try it and there is no error?

jniles commented 9 years ago

From my pull request text:

I've tested most of the modules, and this change leaves them unaffected. However, if we do find issues, we might want to add ng-annotate to our gulp build.

Yup, I tested it. Haven't done a performance comparison, but it didn't slow anything down, as far as I can tell.