Updates for the Statement of Cash Flows report

jmcameron commented 2 years ago

Finance > Report > Statement of Cash Flows

There is small cosmetic bug (or configuration problem). With the Vanga dataset, the legend at the bottom listing the account(s) involved shows duplicate values:

.

My guess is that the names of the two accounts are not correct. They may have the same number but one may be FC and other USD, but both appear to be FC. NOTE: This problem was addressed by an error message in https://github.com/IMA-WorldHealth/bhima/issues/6191

Suggestions

~~Add multi-currency support~~
If this report is related to the other cashflow report (Cashflow by Service), this report should be renamed so that they appear next to each other in the menu

jniles commented 2 years ago

I can shed some light on this - the configuration of two FC accounts for the cashbox exists for historical reasons. We used to require you to configure all currency accounts for a cashbox here:

Since Vanga only deals with FC in it's Caisse Auxiliaire, it was configured with FC for the USD account, long ago, but this was never used. I can work out a patch to remove it from the Vanga database.

jmcameron commented 2 years ago

I can shed some light on this - the configuration of two FC accounts for the cashbox exists for historical reasons. We used to require you to configure all currency accounts for a cashbox here:

Since Vanga only deals with FC in it's Caisse Auxiliaire, it was configured with FC for the USD account, long ago, but this was never used. I can work out a patch to remove it from the Vanga database.

This part has been deferred to Issue https://github.com/IMA-WorldHealth/bhima/issues/6238

jmcameron commented 2 years ago

We currently have three financial cashflow/cashbox reports:

Statement of Cash Flow (Flux de Trésorerie")
- Resulting report title: Cash Flow Physical Report (Rapports de flux de trésorerie physique)
Cash Report (Rapport de Caisse)
- Resulting report title: Cash Report (Rapport de caisse)
Cashflow by Service (Journal de Ventilation)
- Resulting report title: Cash Flow by Service (Journal de Ventilation)

In the description at the top of this issue, I proposed renaming the 'Statement of Cash Flows' report to something that would sort with the other cash flow report (cash flow by service). However, this only works in English since the French names are quite different and not so simple to rename to sort together.

Also some renaming of the menu names for these reports (in English) seems appropriate. For instance:

Doesn't the "Cash Report" relate to cash boxes? Shouldn't the name reflect that?
I propose renaming "Statement of Cash Flows" to "Cash Flows Report" or simply "Cash Flows".
I noticed we have "Cashflow" in some places and "Cash Flow" in others. We should be consistent.

jniles commented 6 months ago

@jmcameron, is my understanding of where this issue stands that:

We should standardize "Cashflow" versus "Cash Flow" in English throughout the application AND
We should rename the English to be "Cash Flows" or "Cash Flows Report" for sorting reasons?

And then we could close it?

jmcameron commented 6 months ago

@jmcameron, is my understanding of where this issue stands that:
1. We should standardize "Cashflow" versus "Cash Flow" in English throughout the application AND

2. We should rename the English to be "Cash Flows" or "Cash Flows Report" for sorting reasons?
And then we could close it?

I suggest "Cash Flow" throughout and I agree with point 2.

jniles commented 6 months ago

Okay, seems like a straightforward fix. Not sure what my schedule will be in the coming days, but may attempt it 👍

IMA-WorldHealth / bhima

Updates for the Statement of Cash Flows report #6183