IMAP-Science-Operations-Center / imap-data-access

Package to download, query, and upload files from the IMAP Science Data Center.
MIT License
0 stars 7 forks source link

BUG - extract_filename_components method #19

Closed tech3371 closed 3 months ago

tech3371 commented 4 months ago

Description of the issue

extract_filename_components method return value needs to match database naming

Code Snippet:

from imap_data_access import ScienceFilePath

filename = "some_valid_filename"
params = ScienceFilePath.extract_filename_components(filename)
print(params)

Expected behavior (What should happen)

pattern = (
            r"^(?P<mission>imap)_"
            r"(?P<instrument>[^_]+)_"
            r"(?P<data_level>[^_]+)_"
            r"(?P<descriptor>[^_]+)_"
            r"(?P<start_date>\d{8})_"
            r"(?P<end_date>\d{8})_"
            r"(?P<version>v\d{2}-\d{2})"
            r"\.(?P<extension>cdf|pkts)$"
        )

Actual behavior (What does happen)

pattern = (
            r"^(?P<mission>imap)_"
            r"(?P<instrument>[^_]+)_"
            r"(?P<datalevel>[^_]+)_"
            r"(?P<descriptor>[^_]+)_"
            r"(?P<startdate>\d{8})_"
            r"(?P<enddate>\d{8})_"
            r"(?P<version>v\d{2}-\d{2})"
            r"\.(?P<extension>cdf|pkts)$"
        )

Additional notes

No response

Affected areas (code, data, or process)

No response

Suggested fix?

No response

maxinelasp commented 4 months ago

Fixed in PR #18