search

IMAP-Science-Operations-Center / imap-data-access

Package to download, query, and upload files from the IMAP Science Data Center.
MIT License
0 stars 7 forks source link

BUG - Query usage response not as expected #30

Closed maxinelasp closed 2 months ago

maxinelasp commented 2 months ago

Description of the issue

When using the "query" option without any arguments, imap-data-access throws an ugly error instead of printing usage.

Steps to reproduce the issue

imap-data-access query

Code Snippet:

imap-data-access query   
Traceback (most recent call last):
  File "/Users/maha7656/Documents/code/imap/venv/bin/imap-data-access", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/maha7656/Documents/code/imap/venv/lib/python3.11/site-packages/imap_data_access/cli.py", line 292, in main
    args.func(args)
  File "/Users/maha7656/Documents/code/imap/venv/lib/python3.11/site-packages/imap_data_access/cli.py", line 108, in _query_parser
    query_results = imap_data_access.query(**query_params)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/maha7656/Documents/code/imap/venv/lib/python3.11/site-packages/imap_data_access/io.py", line 141, in query
    raise ValueError("At least one query parameter must be provided")
ValueError: At least one query parameter must be provided

Expected behavior (What should happen)

❯ imap-data-access upload                                                     
usage: imap-data-access upload [-h] file_path
imap-data-access upload: error: the following arguments are required: file_path
❯ imap-data-access download
usage: imap-data-access download [-h] file_path
imap-data-access download: error: the following arguments are required: file_path

Actual behavior (What does happen)

Error

Additional notes

No response

Affected areas (code, data, or process)

No response

Suggested fix?

No response