search

IMAP-Science-Operations-Center / imap-data-access

Package to download, query, and upload files from the IMAP Science Data Center.
MIT License
0 stars 9 forks source link

BUG - File already download log not showing up #71

Open tech3371 opened 3 months ago

tech3371 commented 3 months ago

Description of the issue

When I try to download same file few times, it doesn't give me message that file was already download both from imap-data-access and imap_cli command line. This message would help save time and understand that our cli is not downloading same file.

Steps to reproduce the issue

download same file using either imap-data-access or imap_cli command

Expected behavior (What should happen)

should give file already download message

Actual behavior (What does happen)

nothing in imap_cli or download successful shows up in imap-data-access cli

Code Snippet:

https://github.com/IMAP-Science-Operations-Center/imap-data-access/blob/main/imap_data_access/io.py#L80

Additional notes, affected areas, and suggested fixes

No response

greglucas commented 3 months ago

The default log level is set to warning. https://docs.python.org/3/howto/logging.html#a-simple-example

You should be able to run with -v to get verbose output, i.e. the INFO level details. Should this be changed to just a standard print message? That does introduce new spam to the output terminal though when you are using the utility as expected with no way of avoiding the message.