search

IMAmuseum / tap-ios

Native iOS (iPhone & iPod) tour application for the TAP mobile application software platform. Learn more about the project at TAPintoMuseums.org.
http://tapintomuseums.org
GNU Lesser General Public License v3.0
13 stars 5 forks source link

Theme override #4

Open hannolans opened 11 years ago

hannolans commented 11 years ago

When you do a checkout of the code your theme images can get overridden with the default images of IMA. Is it possible to have a directory where you can keep your own theme or reorganise it in a separate directory that we can git ignore?

karnold commented 11 years ago

Hi Hanno, The best way to handle this is to create a sub theme for drupal. Sub themes will inherit from the base theme and allow you to override certain functionality. More info is available here http://drupal.org/node/225125

From: Hanno Lans notifications@github.com<mailto:notifications@github.com> Reply-To: IMAmuseum/tap-ios reply@reply.github.com<mailto:reply@reply.github.com> Date: Wed, 26 Sep 2012 13:23:45 -0700 To: IMAmuseum/tap-ios tap-ios@noreply.github.com<mailto:tap-ios@noreply.github.com> Subject: [tap-ios] Theme override (#4)

When you do a checkout of the code your theme images can get overridden with the default images of IMA. Is it possible to have a directory where you can keep your own theme or reorganise it in a separate directory that we can git ignore?

— Reply to this email directly or view it on GitHubhttps://github.com/IMAmuseum/tap-ios/issues/4.

This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact Kris Arnold by reply email and destroy all copies of the original message.

cmoad commented 11 years ago

Looks like this suggestion is specific to the iOS app. In that case, it is a harder question. Forking the repository might be the best approach if you plan on making a round of changes. You can always pull changes across after the fact.

hannolans commented 11 years ago

Yes, this is specific for the iOS app. I would prefer not to fork as we can then contribute and get new changes form the app. Possibly as long as it are only the image files, and the names and dimensions stay the same, it could just work to ignore these image files in git. Is it possible to put these files in a special directory, so you can add this to you .gitignore file?

cmoad commented 11 years ago

I don't think ignoring the media is an option because we want the app to run out of the box. I also don't know of a way that iOS allows you to override graphics. Assigning to Dan to see if he has any ideas. Otherwise I still think forking is easiest. This lets you easily pull changes back and forth including making it easier for you to provide pull requests with enhancements.

hannolans commented 11 years ago

Yes, forking is an option for now. Roadmap for the future could be that museums can upload the theme images in the TAP-CMS and can export this to the app?

dlferro commented 11 years ago

At the moment the only items that we do not currently export on the authoring side are the keypad graphics, the top banner, and the initial animation graphics. Now the initial splash screen and application icon can not be themed this way because they are handled differently by the application.