search

IMB11 / Fog

A total overhaul of Minecraft's fog, offering options to customize fog color, start, and end points. Enjoy a more immersive experience with enhanced depth and visuals, all while keeping the same view distance.
https://modrinth.com/mod/fog
Other
26 stars 6 forks source link

"Resource Reload Failed" After Launch with Frostiful #14

Closed TheDeathlyCow closed 1 month ago

TheDeathlyCow commented 2 months ago

I received two reports, one in TheDeathlyCow/frostiful#100 and one on Discord, of a "Resource Reload Failed" toast appearing after launch with Frostiful installed, and after some investigation, it was discovered that this only occurred when Fog was installed.

The issue seems to occur when the Frost Wand item renderer tries to reload, and fetch the Frost Wand model from the appropriate render layer. For whatever reason, the Frost Wand model layer is not registered when this happens with Fog installed. I have checked that everything is correctly registered through Fabric API, and I believe it is (you can check here, here, and here), so I think the issue has to do with some of the resource reloading going on here. Maybe there is an extra "reload event" being fired?

Note that this error does not seem to be fatal, the game does not crash and all of Frostiful's resources still seem to work just fine - it is just this weird error appearing on launch and in the log.

This is the log that was given to me in the GitHub report: https://mclo.gs/C9OErrM Here is my log, with just Fog and Frostiful (and Frostiful's dependencies): https://mclo.gs/ElF0Lh6

This was tested on Minecraft 1.21, Fabric Loader 0.16.0, and Fabric API 0.102.0

I really like the look of this mod, by the way, will be adding to my normal set of vanilla client mods :)

Steveplays28 commented 2 months ago

Hi, thanks for the report! I'll take a look, might be a timing issue or similar.

ExDrill commented 1 month ago

This exact issue happens with Guarding, I've received several reports about the Netherite Shield model layer, but never figured out which mod was causing it until recently. https://github.com/Team-Abode/guarding/issues/17

Steveplays28 commented 1 month ago

Fixed in Fog v1.4.1.