IMB11 / Fog

A total overhaul of Minecraft's fog, offering options to customize fog color, start, and end points. Enjoy a more immersive experience with enhanced depth and visuals, all while keeping the same view distance.
https://modrinth.com/mod/fog
Other
27 stars 7 forks source link

Animated blocks have no animation (with Sodium `v0.6.0`) #23

Closed anoomolu closed 2 months ago

anoomolu commented 3 months ago

Workaround:

java_Pe4GJju2hq


When Sodium's "Animate Only Visible Textures" setting is enabled, which is the case by default, adding Fog causes the animated texture of fire to become static. Disabling the former setting is a workaround for the issue, but I'm not sure why Fog would cause such an issue to begin with.

Using the following modlist: image

zed1ker commented 3 months ago

same problem

DmanMC commented 2 months ago

its any block texture animation, liquids arent affected

Screencast_20240829_080418.webm

IMB11 commented 2 months ago

This is insanely weird, fixing now.

IMB11 commented 2 months ago

I cant seem to reproduce this on 1.21 with Sodium 0.6, I will try with the older versions.

https://github.com/user-attachments/assets/2038d1d1-31b3-4dd2-a3f0-aad62bd283cd

zed1ker commented 2 months ago

I had it on 1.21, perhaps this is due to a special setting

zed1ker commented 2 months ago

the person who started the issue has several mods, I have a little more of them, but the error occurs only if there is a Fog mod

(animations stop working even on items in the inventory)

https://github.com/user-attachments/assets/29a139aa-eee1-4c68-9f48-f819fa94171c

IMB11 commented 2 months ago

Im not sure, can you remove your mods one by one until the issue no longer occurs? (Obviously keeping Fog and MRU installed.)

IMB11 commented 2 months ago

For now, simply just disable the "Animate only Visible Textures" option as a workaround.

anoomolu commented 2 months ago

Will be home in an hour or so, can check then if the problematic mod isn't found by then.

zed1ker commented 2 months ago

4 mods are installed mru, fog, fabric api and sodium

the video is slightly accelerated to take up less space

https://github.com/user-attachments/assets/2bc68b98-e3d2-4259-b0be-d9568bed5a92

IMB11 commented 2 months ago

Does this happen on 1.21.1 as well?

IMB11 commented 2 months ago

It could be an issue with your GPU, you might have to report this to sodium, I have not a single clue why Fog causes this issue considering we're only modifying the fog manager.

zed1ker commented 2 months ago

is 1.21 maybe something is wrong with my gpu and apparently not only with mine

God-Dnds commented 2 months ago

Same issue here, running only Fog and its required mods. (Side note it gave me an error [fabric-renderer-indigo] and wouldn't launch at all so I added indium and sodium) Fabric 1.21

God-Dnds commented 2 months ago

Addition to previous note all particles seem to disappear as well so it must be breaking something in indigo renderer.

vico93 commented 2 months ago

Having the same issue on 1.21.1 and Sodium 0.6.0.

Steveplays28 commented 2 months ago

@God-Dnds could you reproduce that issue with Indigo and upload your latest.log?

God-Dnds commented 2 months ago

I would but I'm not able to reproduce it so it may have been something else but as far as I know none of the other mods I am using are using Indigo. I was noticing the issue like 2ish hours into playing and I am having to clear logs constantly since for one of the data packs I am using is spitting out literal Gigabytes of log files. I will test without any of that for a few hours and report back

MiraculixxT commented 2 months ago

I also opened an issue on the Sodium GitHub page 2 weeks ago, the issue started with Sodium 0.6 beta. Also uploaded a full log and crashlog for hardware. Issue: https://github.com/CaffeineMC/sodium-fabric/issues/2722

IMB11 commented 2 months ago

This will be fixed in the next version of sodium: https://github.com/CaffeineMC/sodium-fabric/issues/2722

Steveplays28 commented 2 months ago

This issue is also fixed on our side in Fog v1.4.1.