search

IMB11 / Fog

A total overhaul of Minecraft's fog, offering options to customize fog color, start, and end points. Enjoy a more immersive experience with enhanced depth and visuals, all while keeping the same view distance.
https://modrinth.com/mod/fog
Other
27 stars 7 forks source link

FOG breaks mods that have custom dimension fog color #46

Open TelepathicGrunt opened 1 month ago

TelepathicGrunt commented 1 month ago

I gotten a report that FOG mod is breaking the fog color of my Bumblezone mod. https://github.com/TelepathicGrunt/Bumblezone/issues/453#issuecomment-2428879864

I override a method in DimensionSpecialEffects to specify the fog color dynamically for my dimension. FOG does not appear to respect this and continues to treat my dimension with white normal fog. https://github.com/TelepathicGrunt/Bumblezone/blob/4639879203ba97a829c2d1e5bfdf419e8cc936bb/common/src/main/java/com/telepathicgrunt/the_bumblezone/client/dimension/BzDimensionSpecialEffects.java#L25

By default, FOG mod should not be overriding this color against modder’s wishes in my opinion

Steveplays28 commented 1 month ago

Hi TelepathicGrunt, this is currently hardcoded, but there's a TODO comment at the relevant code to de-hardcode it. Another option is to add The Bumblezone to the list of excluded dimensions.

Thanks for the report.

SanQianQVQ commented 1 month ago

Hi TelepathicGrunt, this is currently hardcoded, but there's a TODO comment at the relevant code to de-hardcode it. Another option is to add The Bumblezone to the list of excluded dimensions.

Thanks for the report.

Hi Steveplays28 How to set the dimension to eliminate the list? I didn’t see the relevant settings in wiki and config

Steveplays28 commented 1 month ago

Hi @SanQianQVQ, did you update to Fog v1.5.0 or up? The feature got introduced in Fog v1.5.0.