search

IMB11 / SkinShuffle

Choose and change your skin in-game!
https://modrinth.com/mod/skinshuffle
Other
17 stars 8 forks source link

Crash with bobby #33

Closed Rozbiynk closed 2 weeks ago

Rozbiynk commented 1 year ago

Describe the issue

I check it only with these 2 (3) mods

  1. When minecraft load there is no skin preview
  2. join any server
  3. press escape twice
  4. game crash

Relevant log output

https://mclo.gs/QehGpFd

SkinShuffle version

https://github.com/mineblock11/SkinShuffle/actions/runs/5500800504

Extra information

No response

enjarai commented 1 year ago

Fixed with the latest commit.

Rozbiynk commented 1 year ago

havent crash, but still have problem in console and skin preview doesnt render https://mclo.gs/MoME7CS изображение

enjarai commented 1 year ago

Oh I see, the crashing was more of a symptom than an issue by itself. It seems like Bobby is trying to load a chunk manager for the fake world we use to render the player character, which clearly doesn't work. I'll look at making compatibility.

Rozbiynk commented 1 year ago

do i need open issue on bobby's github?

enjarai commented 1 year ago

That might be worth doing to help coordinate a fix yes. This seems like a relatively complex issue at first glance.

IMB11 commented 2 weeks ago

Bobby author does not want to backport their fix to 1.20.1, will be putting a "breaks": "bobby" for 1.20.1 jars unfortunately.