search

IMB11 / SkinShuffle

Choose and change your skin in-game!
https://modrinth.com/mod/skinshuffle
Other
17 stars 8 forks source link

Typing Colon Crashes Game #66

Closed Ashy8682 closed 1 month ago

Ashy8682 commented 3 months ago

Describe the issue

In the textbox used for typing in a file path, trying to type "C:" crashes the game, but if there's already a path in front of the colon it doesn't.

I believe SkinShuffle may be attempting to search the entirety of the C: drive, which would obviously crash the game. If that's the case, my suggestion would be to have it only search the path when you click refresh, and maybe even have it ignore drive letters if someone puts one in by itself for some reason.

Relevant log output

No response

SkinShuffle version

1.1.0+1.20.4

Extra information

No response

Ashy8682 commented 2 months ago

I believe SkinShuffle may be attempting to search the entirety of the C: drive, which would obviously crash the game. If that's the case, my suggestion would be to have it only search the path when you click refresh, and maybe even have it ignore drive letters if someone puts one in by itself for some reason.

Upon further investigation, this is not the case. Here's the logs error: Caused by: java.lang.IllegalArgumentException: NTFS ADS separator (':') in file name is forbidden.