search

IMB11 / SkinShuffle

Choose and change your skin in-game!
https://modrinth.com/mod/skinshuffle
Other
17 stars 8 forks source link

Fast skin refreshing for players with the mod installed #70

Closed DimasKama closed 1 month ago

DimasKama commented 2 months ago

The main idea: do not completely reload the player entity for people with the mod installed.

For players with the mod, one packet is simply sent indicating that they need to update the play list entry, which contains the cached old skin.

I know you are working on updating the server side of the mod, this solution may be temporary until you come up with a better implementation.

Tested this on two local 1.20.4 clients with no other mods

IMB11 commented 2 months ago

Thanks for this, I'll be looking at this in the coming month as I have exams.

Unless @enjarai wants to sort this out.

enjarai commented 2 months ago

I'm not able to do proper testing right now, but the code looks good to me. It definitely makes sense to have something like this.