search

IMFS-MMB / mmb-gui-electron

Electron-vue based GUI of the Macroeconomic Model Database
http://www.macromodelbase.com
Other
7 stars 16 forks source link

Unselect models -> IRF of unselected NOT shown, autocorrelation functions still shown #120

Closed AlexDece closed 4 years ago

AlexDece commented 4 years ago

Describe the bug I don't know if this is a bug or intentional. If you click on the modelname above the IRFs, then the IRF of the model is not shown anymore (what is expected). However, the autocorellation function of this model is still in the graph (not expected). The problem appears for non-AL models, too.

To Reproduce Steps to reproduce the behavior:

  1. Simulate more than one model (here: 6 AL models)
  2. Click on models name above the IRFs to remove them from the IRF/ACF
  3. See screenshot

Expected behavior I expected that the autocorrelation function of the unselected models to be removed from the ACF graph.

Screenshots screen 1: problem_autocorr

screen 2: problem_autocorr_2

Desktop (please complete the following information):

AlexDece commented 4 years ago

Also notice in screen 2 that the ACF of one model is shown for 2 or 3 periods instead of 10.

j2L4e commented 4 years ago

the autocorellation function of this model is still in the graph (not expected).

thanks, fixed via 721e172

Also notice in screen 2 that the ACF of one model is shown for 2 or 3 periods instead of 10.

That's a bug in the model i'd say, you should file a separate issue for that