IMFS-MMB / mmb-gui-electron

Electron-vue based GUI of the Macroeconomic Model Database
http://www.macromodelbase.com
Other
7 stars 16 forks source link

Model comparison #73

Closed cch388 closed 4 years ago

cch388 commented 4 years ago

When comparing two models, sometimes only the model of which name is alphabetically listed beforehand shows the impulse response.

Example 1:

  1. Tick US_AJ16 and US_BKM12
  2. Tick Taylor
  3. Tick Technology shock
  4. Tick Inflation
  5. The interface says that technology shock (ea and eps_z) are unavailable for the models (see screenshot below). Screen Shot 2019-11-25 at 3 21 01 PM Screen Shot 2019-11-25 at 3 22 14 PM
  6. Only US_AJ16 impulse response appears as A is alphabetically before B (see screenshot below). Screen Shot 2019-11-25 at 3 02 01 PM

Example 2:

  1. Tick US_AJ16 and EA_ALSV06
  2. Tick Taylor
  3. Tick Technology shock
  4. Tick Inflation
  5. The interface says that technology shock (epsz and epsz) are unavailable for the models (see screenshot below). Screen Shot 2019-11-25 at 3 25 09 PM Screen Shot 2019-11-25 at 3 25 23 PM
  6. Only EA_ALSV06 impulse response appears as E is alphabetically before U (see screenshot below). Screen Shot 2019-11-25 at 3 04 20 PM

But sometimes the alphabetical order doesn't matter.

Example 3:

  1. Tick US_BKM12 and US_CCTW10
  2. Tick Taylor
  3. Tick Technology shock
  4. Tick Inflation
  5. Both US_BKM12 and US_CCTW10 impulse response appear (see screenshot below). Screen Shot 2019-11-25 at 3 12 44 PM

However, if just simulating one individual, impulse response appears anyways.

Example 4:

  1. Tick US_BKM12
  2. Tick Taylor
  3. Tick Technology shock
  4. Tick Inflation
  5. US_BKM12 impulse response appears (but it's not shown when comparing with US_AJ16). Screen Shot 2019-11-25 at 3 05 30 PM
cch388 commented 4 years ago

Jonas also has the same problem btw. And I am running all these on my Macbook with MatLab.

j2L4e commented 4 years ago

fixed.

The interface says that technology shock (ea and eps_z) are unavailable for the models (see screenshot below).

The way shocks are selected and passed to the backend wasn't designed for "same text/different name" kinds of shocks as this came up very recently, so the script warns about some of them not being available. It's a cosmetic thing.

j2L4e commented 4 years ago

Btw, these are not correctly named in master, yet. You'll need to fix #66 for that