search

IMGIITRoorkee / chakra-library

3 stars 7 forks source link

Typography Styles #61

Closed Yavnikaa closed 2 years ago

Yavnikaa commented 3 years ago

There must be typography elements of headings (like h1 h2 in HTML). These should be consistent in all components. It is already there in IITR UI kit. Please work on these!

Screenshot (39)

aitalshashank2 commented 2 years ago

Merged #85 into staging. @Yavnikaa please review here.

Yavnikaa commented 2 years ago

Looks fine! Bass font size theme ke according rakha he naa? kyuki accessibility features honge font size increase decrease karne ke, toh hardcode mat karnaa font size but variable jaise.

Yavnikaa commented 2 years ago

Looks fine! Bass font size theme ke according rakha he naa? kyuki accessibility features honge font size increase decrease karne ke, toh hardcode mat karnaa font size but variable jaise.

saurabhhere commented 2 years ago

@aitalshashank2 font size increase decrease to rem se hi ho jayega na direct accessibility features mein

saurabhhere commented 2 years ago

@Yavnikaa Agr typography mein bhi inverted daalna hai kahi, toh uska design daal dena yaha pr

Yavnikaa commented 2 years ago

@Yavnikaa Agr typography mein bhi inverted daalna hai kahi, toh uska design daal dena yaha pr

IITR UI kit vali file mei dekh yeh blue box vala, jo section heading likhaa hua he, vahi haii.

aitalshashank2 commented 2 years ago

Inverted typography merged to staging via #102. @Yavnikaa please review.

Yavnikaa commented 2 years ago

cool