Validate if `end_date` is after or same as `start_date`

IMGIITRoorkee / omniport-backend-formula-one

The backend blocks of Omniport, expressed as a collection of frequently-used classes and functions

GNU General Public License v3.0

9 stars 2 forks source link

Closed algomaster99 closed 4 years ago

algomaster99 commented 4 years ago

These changes will throw 500 in some apps. We can take care of the errors in case Sentry reports them or simply by code inspection.

pradumangoyal commented 4 years ago

In my opinion, there isn't an issue when the start date and end date are the same.

algomaster99 commented 4 years ago

@pradumangoyal yes, I have made sure a user can do that.

pradumangoyal commented 4 years ago

Oh sorry, I got confused by the PR title. 😅

algomaster99 commented 4 years ago

@pradumangoyal I will check this branch out on 227 and test it before merging?

pradumangoyal commented 4 years ago

Better to check it on our staging server i.e. 228

algomaster99 commented 4 years ago

@dhruvkb @pradumangoyal used a better method to check the validation as suggested by the Django docs.