IMIO / helm-plausible-analytics

Helm Chart for Plausible Analytics
Apache License 2.0
10 stars 10 forks source link

Use existing secret rework #4

Closed mrdotb closed 11 months ago

mrdotb commented 11 months ago

What this PR does / why we need it:

Use existing secret.

Changes:

I added the ability to bring an existing secrets that we discussed in #3.

I separated the values related to postgres and clickhouse optional deps to be first level databaseURL, clickhouseDatabaseURL We can discuss this but I feel like it's confusing to access values from deps that are not supported in their chart and if you want to bring your own postgres or clickhouse it make more sense.

I got ride of the secrets postgres and clickhouse password ... that are only used in the init containers and replaced that by parsing the DB URL in scripts instead. I also moved the init container check on first level for the same reasons as before. I also got ride of the clickhouse curl check not sure why two scripts are needed ?

I updated the plausible ENV some where removed some where added. (twitter, adminUser, mailer ...)

The chart version need to be bumped but I will do that after the review.

There is an issue with the CI does not seem related with my changes ERROR: Unable to validate cosign version: 'v2.0.0'

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]