Closed ptitmouton closed 7 months ago
Hi,
I found an issue with the extraEnv option introduced in #4
Adding the following option to values.yaml:
extraEnv: - name: NAME value: VALUE - name: OTHER value: VALUE2
Leads to the following deployment.yaml in the template (which fails to deploy):
<...> - name: CLICKHOUSE_DATABASE_URL valueFrom: secretKeyRef: key: CLICKHOUSE_DATABASE_URL name: plausible-plausible-analytics - name: NAME value: VALUE - name: OTHER value: VALUE2 <...>
There are two problems with https://github.com/IMIO/helm-plausible-analytics/blob/f480d867bbfa6d028830cd05a6d3e30cb4ffa98e/templates/deployment.yaml#L225
{{ toYaml .Values.extraEnv | indent 10 }}
In the hope I can help with this PR.
Thanks @ptitmouton! I also made a fix, I changed the indent function into the nindentfunction for extraEnv. Let me now if all work for you.
indent
nindent
I did not know about nindent. Works perfectly, thank you!
Hi,
I found an issue with the extraEnv option introduced in #4
Adding the following option to values.yaml:
Leads to the following deployment.yaml in the template (which fails to deploy):
There are two problems with https://github.com/IMIO/helm-plausible-analytics/blob/f480d867bbfa6d028830cd05a6d3e30cb4ffa98e/templates/deployment.yaml#L225
{{ toYaml .Values.extraEnv | indent 10 }}
are included in the output templateIn the hope I can help with this PR.
Checklist