IMLS / estimating-wifi

Estimating Wifi is a pilot project to automate the censusing of proximal wifi devices via low-cost and open source tools.
https://10x.gsa.gov/projects/shared-components-for-museums-and-libraries/
Other
10 stars 3 forks source link

Refactor date selector + add heatmap unit tests #220

Closed sknep closed 2 years ago

sknep commented 2 years ago

This PR finishes some work that was merged in partially complete last week. It more reliably watches changes to the selected date and surfaces that via a query parameter in the URL, allowing users to link to specific days. By default, the library page opens with yesterday's data (note that our sample data only covers May 2022 right now), although each date selection change now updates the browser history. This removes the need for storing a selectedDate in shared state across the app, as the selected date is now available from the router and is passed in to the library page view as a prop. This also updates the Fetch Data wrapper to consume the date as a prop passed in from parent, rather than shared in state, enabling simultaneous use with different start dates. Finally, this PR adds unit test coverage for the two heatmaps, as that work was unfinished when the previous branch merged.

github-actions[bot] commented 2 years ago

🦙 MegaLinter status: :warning: WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ JAVASCRIPT prettier 8 0 0 1.63s
✅ JSON eslint-plugin-jsonc 1 0 0 2.2s
✅ JSON jsonlint 1 0 0.28s
✅ JSON prettier 1 0 0 1.44s
✅ JSON v8r 1 0 6.19s
✅ REPOSITORY checkov yes no 10.65s
:warning: REPOSITORY devskim yes 1 1.68s
✅ REPOSITORY dustilock yes no 1.31s
✅ REPOSITORY gitleaks yes no 2.72s
✅ REPOSITORY git_diff yes no 0.54s
✅ REPOSITORY secretlint yes no 4.22s
✅ REPOSITORY syft yes no 0.52s
:warning: REPOSITORY trivy yes 1 3.71s

See errors details in artifact MegaLinter reports on CI Job page _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

anagradova commented 2 years ago

I just went through the changes and code, looks good as far as I can tell.