IMRCLab / libmotioncapture

Interface Abstraction for Motion Capture System APIs such as VICON or OptiTrack
MIT License
13 stars 12 forks source link

New PyPI release with updated Python versions? #11

Closed ntamas closed 1 year ago

ntamas commented 1 year ago

First of all, thanks for this great package, it saved me a lot of time when developing mocap support for Crazyflie drones in Skybrush (see here for the Skybrush server extension where we use libmotioncapture).

Is there any chance for a new release on PyPI with the recent commits, targeted at newer Python versions (3.10 and 3.11)? Version 1.0a1 has support only up to Python 3.9. If you don't have time for this but you are willing to accept a PR, let me know and I'll look into this. Ultimately, I'd like to make sure that motioncapture is pip-installable on Python 3.10 and 3.11 as we intend to move on to newer Python versions.

krichardsson commented 1 year ago

I agree, yes please make it compatible with later python versions :-)

I was looking a bit at using it in the python lib (https://github.com/bitcraze/crazyflie-lib-python/issues/411) but also bumped into this problem .

whoenig commented 1 year ago

In principle this should be easy (see https://github.com/IMRCLab/libmotioncapture/pull/13), but currently the Mac doesn't work in CI (simply times out). Have you had this problem before @krichardsson ?

whoenig commented 1 year ago

Nevermind Kristoffer, I found it. The code here is actually almost identically to the one at https://github.com/bitcraze/crazyflie-link-cpp, which was updated earlier. Good idea with having a weekly cron-job, too.

whoenig commented 1 year ago

There is a new release now, including for Python 3.10 and 3.11.