search

IMRCLab / libmotioncapture

Interface Abstraction for Motion Capture System APIs such as VICON or OptiTrack
MIT License
13 stars 12 forks source link

Qualisys fix #6

Closed knmcguire closed 2 years ago

knmcguire commented 2 years ago

Hi!

In the light of the latest release, we started to look in some Qualisys issues in our cfclient and lib (https://github.com/bitcraze/crazyflie-clients-python/pull/567) .

Although that that fix is not related to the problems in this lib, I did go through the rabbit hole a bit further and managed to fix the qualisys issues in this lib as well related to #3. I did these changes on top of the commit that Wolfgang already did in the branch issue3

whoenig commented 2 years ago

Excellent - thanks!

By the way, it could be nice to use this libraries' pip-version in both cfclient and cflib. Advantage for you: you'll support most mocap systems out of the box (users just contributed NOKOV). Advantage for me: this library gets more heavily tested (& more user-contributions like this, to keep it up for the various different systems).

There is currently a preliminary version on pip, but I could update that (and the bindings to support more features), if that is something you are planning to switching to.

knmcguire commented 2 years ago

Good point! Perhaps not for this release as there are many other things to fix but I'll discuss it for after the release we can do a master merge.

Nice thing is that we would be able to support vicon and optitrack from our cfclient too 😁