Please check the following before creating the pull request (PR):
[x] Did you run automatic tests?
As described in #307 this automatic test fails locally, but should work on github.
[x] Did you run manual tests?
We noticed that the acoustic_forward_model test yield wrong results. The directions of the reconstructed images are flipped. This is most likely not related to our code changes, but rather to #270. This should be addressed together with #163.Edit: This was only a local configuration error with a wrong virtual environment still having the old SIMPA version
[ ] Is the code provided in the PR still backwards compatible to previous SIMPA versions?
It's complicated. It's backwards compatible if you only simulate a pipeline. But once you import SimulationModules you have to adjust the path from .core to .core.simulation_modules. So this mostly affects developers of new adapters.
List any specific code review questions
Are there more things to refactor into PipelineModules or SimulationModules ?
Provide issue / feature request fixed by this PR
Fixes #303
Please check the following before creating the pull request (PR):
[x] Did you run automatic tests? As described in #307 this automatic test fails locally, but should work on github.
[x] Did you run manual tests?
We noticed that the acoustic_forward_model test yield wrong results. The directions of the reconstructed images are flipped. This is most likely not related to our code changes, but rather to #270. This should be addressed together with #163.Edit: This was only a local configuration error with a wrong virtual environment still having the old SIMPA version[ ] Is the code provided in the PR still backwards compatible to previous SIMPA versions? It's complicated. It's backwards compatible if you only simulate a pipeline. But once you import
SimulationModules
you have to adjust the path from.core
to.core.simulation_modules
. So this mostly affects developers of new adapters.List any specific code review questions Are there more things to refactor into PipelineModules or SimulationModules ?
Provide issue / feature request fixed by this PR Fixes #303