T105 overview manual test

IMSY-DKFZ / simpa

The Simulation and Image Processing for Photonics and Acoustics (SIMPA) toolkit.

https://simpa.readthedocs.io/en/main/

Other

73 stars 18 forks source link

T105 overview manual test #318

Closed cbender98 closed 2 months ago

cbender98 commented 3 months ago

Please check the following before creating the pull request (PR):

[x] Did you run automatic tests?
[x] Did you run manual tests?
[x] Is the code provided in the PR still backwards compatible to previous SIMPA versions?

List any specific code review questions I added new dependencies. Please check if this is fine.

List any special testing requirements

Additional context (e.g. papers, documentation, blog posts, ...)

Provide issue / feature request fixed by this PR

Fixes #105

frisograce commented 3 months ago

Please add information about that functionality in the readme.

Holzwarth69126 commented 3 months ago

We (@kdreher @frisograce ) were not able to generate an HTML file on two different workstations. The .md file and figures were created and looked ok. The HTML file was created but seemed to be empty.

@cbender98 could you please look into that? Either there is a bug somewhere or the documentation should be updated.

TomTomRixRix commented 2 months ago

We (@kdreher @frisograce ) were not able to generate an HTML file on two different workstations. The .md file and figures were created and looked ok. The HTML file was created but seemed to be empty.

@cbender98 could you please look into that? Either there is a bug somewhere or the documentation should be updated.

When running the manual test generate_overview.py on my computer the HTML file with content was created without errors. Of course I had to run pip install . to install the dependencies.

frisograce commented 2 months ago

Checked this all on a clean version of simpa, and it all worked. Only one problem where the reconstucted image for KWaveAcousticForwardConvenienceFunction isn't working, but I dont know if this could be a me problem.

cbender98 commented 2 months ago

[x] put new requirements in optional requirements
[x] add feature to create own reference figure folder (with logging simpa version)

cbender98 commented 2 months ago

ready to merge. above requested changes have been addressed. @kdreher @jgroehl you can a have a final look over it.