search

IMTEK-Simulation / NuMPI

Utilities for MPI-parallel numerical calculations with Python
MIT License
2 stars 1 forks source link

Feat/20 optimizer #37

Closed sindhu2993 closed 3 years ago

sannant commented 4 years ago

I convert this into a draft for now since I am not sure we want to merge it yet

sindhu2993 commented 3 years ago

A small review here as well @AntoineSIMTEK on polonsky-keer cg serial implementation.

pastewka commented 3 years ago

What happened to this MR? Can we merge it?

sannant commented 3 years ago

We are still polishing up. I will request your review once we think it is ready.

sindhu2993 commented 3 years ago

@AntoineSIMTEK I think this is done now.

sannant commented 3 years ago

@pastewka I think it is ready for your eyes

sannant commented 3 years ago

@pastewka all comments have been adressed. I think can be merged now. I don't think it needs a full review again.

sannant commented 3 years ago

@pastewka I have one question: is the structure of the optimisation module or should I import the ccgs in the __init__ file ?

I would then rename the functions from "constrained_conjugate_gradients" "ccg_without_restart" etc...